Fixed GH-21077. Fixed stub for Dom\Node::baseURI#21078
Closed
mbeccati wants to merge 1 commit intophp:PHP-8.4from
Closed
Fixed GH-21077. Fixed stub for Dom\Node::baseURI#21078mbeccati wants to merge 1 commit intophp:PHP-8.4from
mbeccati wants to merge 1 commit intophp:PHP-8.4from
Conversation
ndossche
requested changes
Jan 29, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
The stub was right, it should not be nullable.
The problem is that the implementation class can create a dtd without a document. This means that the "follows spec" check fails in the baseuri read implementation.
Contributor
Author
|
@ndossche Apologies, I had mistakenly checked the docs for the old \DomNode. Any suggestions? |
Member
|
See #21082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21077